[2.x] PHP 8.4 support

[Jubeki]

PestPHP doesn't support PHP 8.4 yet, and can therefor not be installed without the platform-req=php+

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[driesvints]

I'd honestly like to wait until it does support php 8.4 so we don't have to use platform-req=php

[Jubeki]

Yeah that's why I left it in Draft for now. Just wanted to see if something else's needed to be fixed.

[crynobone]

@Jubeki I made a draft PR #91 just to experiment around. I closed it once I'm done with testing and applies the changes here.

[crynobone]

I'm curious what would cause this error on PHP 8.4 tests https://github.com/laravel/framework/actions/runs/11024490854/job/30617746097

[Jubeki]

@crynobone maybe this is a little helpful (I don't know much about serialising closures yet)

Following Code snippet causes the error in the test ImplicitRouteBindingTest::test_it_can_resolve_the_implicit_backed_enum_route_bindings_for_the_given_route (first one in your image):
https://github.com/laravel/framework/blob/b17b2bd8ebcb850a909fd046c380d075fd2f118b/src/Illuminate/Routing/RouteSignatureParameters.php#L19-L23

This is the value of $action['uses'] for

PHP 8.3:

O:55:"Laravel\SerializableClosure\UnsignedSerializableClosure":1:{s:12:"serializable";O:46:"Laravel\SerializableClosure\Serializers\Native":5:{s:3:"use";a:0:{}s:8:"function";s:114:"function (\Illuminate\Tests\Routing\CategoryBackedEnum $category) {\n
            return $category->value;\n
        }";s:5:"scope";s:49:"Illuminate\Tests\Routing\ImplicitRouteBindingTest";s:4:"this";N;s:4:"self";s:32:"00000000000001060000000000000000";}}

PHP 8.4:

O:55:"Laravel\SerializableClosure\UnsignedSerializableClosure":1:{s:12:"serializable";O:46:"Laravel\SerializableClosure\Serializers\Native":5:{s:3:"use";a:0:{}s:8:"function";s:123:"function (\{closure:Illuminate\Tests\Routing\CategoryBackedEnum $category) {\n
            return $category->value;\n
        }";s:5:"scope";s:49:"Illuminate\Tests\Routing\ImplicitRouteBindingTest";s:4:"this";N;s:4:"self";s:32:"00000000000001060000000000000000";}}

See the small difference s:114 -> s:123? and function (\Illuminate\Tests\Routing\CategoryBackedEnum $category) -> function (\{closure:Illuminate\Tests\Routing\CategoryBackedEnum $category)

Not sure if this helpful, but maybe a starting point for further debugging.

[Jubeki]

@crynobone I think this PR is related:

• Include the source location in Closure names php/php-src#13550

How to fix this:

serializable-closure/src/Serializers/Native.php

Lines 140 to 142 in 43244bf

	$code = $reflector->getCode();

Instead use the following:

$code = $reflector->getCode();
$code = str_replace('\{closure:', '', $code);

In the end, I think this is a bug with PHP and should probably be reported.

[takaram]

I submitted an issue to php-src and they changed the return value of ReflectionFunction::getNamespaceName().
php/php-src#16122

Here's a sample code of how the reflection methods related to closure namespace work in PHP8.4.
https://3v4l.org/srIno/rfc

Now ReflectionFunction::getNamespaceName() returns "" for anonymous functions.
$reflection->getClosureScopeClass()->getNamespaceName() will still work only if the closure is created in a method. Otherwise the namespace seems unable to be retrieved in a simple way.