Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Scale=MatchAveragecase option #490

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

IsaacOscar
Copy link
Contributor

Status

READY

Description

I have added a Scale=MatchAveragecase option to complement Scale=MatchLowercase and Scale=MatchUppercase, it simply sets the Scale to the average of what MatchLowercase and MatchUppercase would do. This is usefull when you can't make up your mind whether to use MatchLowercase or MatchUppercase, or when neither looks good, as in the example below (where in my opinion, the MatchAveragecase version looks the best)

Todos

  • Tests added to cover new/fixed functionality
  • Documentation if necessary
  • Code follows expl3 style guidelines

Minimal example demonstrating the new/fixed functionality

\setmainfont{TeXGyreSchola}
\newfontfamily\lc[Scale=MatchLowercase]{Fira Math}
\newfontfamily\uc[Scale=MatchUppercase]{Fira Math}
\newfontfamily\ac[Scale=MatchAveragecase]{Fira Math}
\begin{document}
\noindent
Lower {\lc and UPPER} CASE\\
Lower {\uc and UPPER} CASE\\
Lower {\ac and UPPER} CASE
\end{document}

@wspr
Copy link
Collaborator

wspr commented Oct 21, 2023

Thanks! That’s a nice idea. I tried for a few minutes to think of a better name for the option but nothing jumped out at me.

I’m not working frequently on the fontspec code at the moment so if you don’t see anything happen here for a while please don’t hesitate to ping me again about this.

@wspr wspr merged commit 124c91c into latex3:develop Feb 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants