Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyval for package options #493

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Use keyval for package options #493

merged 4 commits into from
Dec 18, 2023

Conversation

u-fischer
Copy link
Member

Status

READY

Description

  • changes the package option to the new keyval-handler to avoid option clash errors.
  • removed the euenc code
  • made the euenc and tuenc option obsolete.

Todos

  • Tests added to cover new/fixed functionality
  • Documentation if necessary
  • Code follows expl3 style guidelines

Minimal example demonstrating the new/fixed functionality

\documentclass{article}
\usepackage{fontspec}
\usepackage[no-math]{fontspec}
\begin{document}
hello $\mathrm{a}$ 
\end{document}

Copy link
Member

@davidcarlisle davidcarlisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good but tests are failing in gh

@zauguin zauguin merged commit 3c11f26 into develop Dec 18, 2023
4 checks passed
@zauguin zauguin deleted the use-keyval branch December 18, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants