Skip to content

Commit

Permalink
remove unneeded bidi firstaid
Browse files Browse the repository at this point in the history
  • Loading branch information
u-fischer committed Jul 18, 2023
1 parent 2121cb1 commit 1ec2223
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 52 deletions.
1 change: 1 addition & 0 deletions required/firstaid/changes.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
2023-07-18 Ulrike Fischer <Ulrike.Fischer@latex-project.org>
* latex2e-first-aid-for-external-files.dtx: remove no longer needed code for
everysel
* latex2e-first-aid-for-external-files.dtx: remove no longer needed code for bidi

2023-05-20 Ulrike Fischer <Ulrike.Fischer@latex-project.org>

Expand Down
52 changes: 0 additions & 52 deletions required/firstaid/latex2e-first-aid-for-external-files.dtx
Original file line number Diff line number Diff line change
Expand Up @@ -285,62 +285,10 @@
%</filehook-ltx>
% \end{macrocode}
%
%
%
%
% \subsection{The \pkg{bidi} package first aid}
%
% The \pkg{bidi} package adds a lot of hooks in various places and
% those added to \cs{document} and \cs{enddocument} are now no
% longer necessary as the kernel already provides the right hooks
% there.
%
% However, we aren't trying to change that but instead only make
% sure that the existing patches still work by adding some first
% aid after \pkg{biditools} has been loaded.
%
% If the package gets updated one can easily take that out simply
% through
%\begin{verbatim}
% \RemoveFromHook{file/biditools.sty/after}[firstaid]
%\end{verbatim}
% This makes it easy to test new bidi code while the first aid code
% is still in the kernel.
%
% \begin{macrocode}
%<*kernel>
% \end{macrocode}
%
% Bidi is now ar a new version: patches are no longer needed.
% \begin{macrocode}
%\AddToHook{file/biditools.sty/after}[firstaid]{%
% \FirstAidNeededT{biditools}{sty}%
% {2020/05/13 v2 Programming tools for bidi package}%
% {%
% \end{macrocode}
% \pkg{bidi} adds some code to the beginning of \cs{document} which
% contains \cs{endgroup} and \cs{begingroup} which is no longer
% correct.
%
% Patching \cs{document} using \cs{bidi@patchcmd} doesn't work so
% we take the extra groups out by hand:
% \begin{macrocode}
% \def\firstaid@bidi@document@patch
% \endgroup#1\begingroup#2\firstaid@bidi@document@patch
% {\unexpanded{#1#2}}%
% \edef\document{\expandafter\firstaid@bidi@document@patch\document
% \firstaid@bidi@document@patch}%
% \end{macrocode}
% There are also some patches into \cs{enddocument}, some continue
% to go in but one fails, so we add that now into the right place.
% \begin{macrocode}
% \AddToHook{enddocument/info}%
% {\let\bidi@AfterEndDocumentCheckLabelsRerun\@firstofone
% \bidi@afterenddocumentchecklabelsrerunhook}%
% }%
%}
% \end{macrocode}
%
% \subsection{The \pkg{dinbrief} class first aid}
%
% Again a case of a no longer correct \cs{endgroup} in document.
Expand Down

0 comments on commit 1ec2223

Please sign in to comment.