Skip to content

Commit

Permalink
missing braces around opt arg, latex3/tagging-project#725 (#1484)
Browse files Browse the repository at this point in the history
  • Loading branch information
@u-fischer
u-fischer authored Oct 4, 2024
1 parent 1fb7f97 commit d508a8d
Show file tree
Hide file tree
Showing 5 changed files with 606 additions and 5 deletions.
4 changes: 4 additions & 0 deletions required/latex-lab/changes.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2024-10-04 Ulrike Fischer <Ulrike.Fischer@latex-project.org>
* latex-lab-sec.dtx (subsection{Sockets}):
add missing braces around optional arg (tagging/725)

2024-10-02 Ulrike Fischer <Ulrike.Fischer@latex-project.org>
* latex-lab-math.dtx (subsection{Sockets}):
disable paratagging in inline math (tagging/711)
Expand Down
11 changes: 6 additions & 5 deletions required/latex-lab/latex-lab-sec.dtx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
%
% for those people who are interested or want to report an issue.
%
\def\ltlabsecdate{2024-09-24}
\def\ltlabsecversion{0.84e}
\def\ltlabsecdate{2024-10-04}
\def\ltlabsecversion{0.84f}
%<*driver>
\documentclass[kernel]{l3doc}
\EnableCrossrefs
Expand Down Expand Up @@ -444,6 +444,7 @@
% The tagging inside relies on the para tagging.
% We do not yet use keyval in the optional argument, as this requires latex-dev
% and the naming of the keys and their key family is unclear.
% \changes{v0.84f}{2024/10/04}{Added braces around optional arg (tagging/725)}
% \begin{macrocode}
\AddToHook{class/after}
{
Expand Down Expand Up @@ -487,7 +488,7 @@
\IfBooleanTF
{#1}
{ \@spart {#3} }
{ \@part [#2]{#3} }
{ \@part [{#2}]{#3} }
% \end{macrocode}
% and now the closing command for the tagging of the title.
% \begin{macrocode}
Expand Down Expand Up @@ -539,7 +540,7 @@
\IfBooleanTF
{#1}
{ \@schapter {#3} }
{ \@chapter [#2]{#3} }
{ \@chapter [{#2}]{#3} }
% \end{macrocode}
% and now the closing command for the tagging of the title.
% \begin{macrocode}
Expand Down Expand Up @@ -594,7 +595,7 @@
\IfBooleanTF
{#1}
{ \@spart {#3} }
{ \@part [#2]{#3} }
{ \@part [{#2}]{#3} }
% \end{macrocode}
% and now the closing command for the tagging of the title.
% \begin{macrocode}
Expand Down
282 changes: 282 additions & 0 deletions required/latex-lab/testfiles-sec/test-gh725-opt-arg.luatex.tlg
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,282 @@
This is a generated file for the l3build validation system.
Don't change this file in any respect.
Completed box being shipped out [1]
\vbox(627.36243+0.0)x380.0, direction TLT
.\hbox(0.0+0.0)x0.0, direction TLT
..\kern-72.26999
..\vbox(0.0+0.0)x0.0, glue set 72.26999fil, direction TLT
...\kern-72.26999
...\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\latelua0{ltx.__pdf.backend_ThisPage_gpush(tex.count["g_shipout_readonly_int"])}
....\glue 0.0 plus 1.0fil minus 1.0fil
...\glue 0.0 plus 1.0fil minus 1.0fil
.\glue 22.0
.\vbox(605.36243+0.0)x345.0, shifted 35.0, direction TLT
..\vbox(12.0+0.0)x345.0, glue set 12.0fil, direction TLT
...\glue 0.0 plus 1.0fil
...\pdflinkstate 1
...\hbox(0.0+0.0)x345.0, direction TLT
....\hbox(0.0+0.0)x345.0, direction TLT
...\pdflinkstate 0
..\glue 18.06749
..\glue(\lineskip) 0.0
..\vbox(550.0+0.0)x345.0, glue set 154.59334fil, direction TLT
...\latelua0{ltx.__pdf.Page.Resources.ExtGState=true}
...\latelua0{ltx.pdf.Page_Resources_gpush(tex.count["g_shipout_readonly_int"])}
...\write-{}
...\write-{}
...\glue(\topskip) 10.0
...\hbox(0.0+0.0)x0.0, direction TLT
...\glue 0.0 plus 1.0fil
...\write1{\@writefile{toc}{\protect \contentsline {part}{I\protect \hspace {1em}Part ]}{\thepage }{part.1}\protected@file@percent }}
...\marks1{\__mark_id:n {1}}
...\marks2{\__mark_id:n {2}}
...\mark{{}{}}
...\glue(\parskip) 0.0 plus 1.0
...\glue(\parskip) 0.0
...\glue(\baselineskip) 10.77005
...\hbox(14.22995+0.0)x345.0, glue set 141.64804fil, direction TLT
....\glue(\leftskip) 0.0 plus 1.0fil
....\localpar
.....\localinterlinepenalty=0
.....\localbrokenpenalty=0
.....\localleftbox=null
.....\localrightbox=null
....\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/bx/n/20.74 P
....\kern-0.64813 (font)
....\OT1/cmr/bx/n/20.74 a
....\OT1/cmr/bx/n/20.74 r
....\OT1/cmr/bx/n/20.74 t
....\penalty 10000
....\TU/lmr/m/n/10
....\glue(\spaceskip) 4.4475 plus 3.88875 minus 2.5925
....\OT1/cmr/bx/n/20.74 I
....\penalty 10000
....\glue(\parfillskip) 0.0
....\glue(\rightskip) 0.0 plus 1.0fil
...\glue 20.0
...\glue(\parskip) 0.0 plus 1.0
...\glue(\parskip) 0.0
...\glue(\baselineskip) 11.34
...\hbox(18.66+6.22)x345.0, glue set 136.81418fil, direction TLT
....\glue(\leftskip) 0.0 plus 1.0fil
....\localpar
.....\localinterlinepenalty=0
.....\localbrokenpenalty=0
.....\localleftbox=null
.....\localrightbox=null
....\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/bx/n/24.88 P
....\kern-0.77751 (font)
....\OT1/cmr/bx/n/24.88 a
....\OT1/cmr/bx/n/24.88 r
....\OT1/cmr/bx/n/24.88 t
....\TU/lmr/m/n/10
....\glue(\spaceskip) 6.0 plus 4.665 minus 3.11
....\OT1/cmr/bx/n/24.88 ]
....\penalty 10000
....\glue(\parfillskip) 0.0
....\glue(\rightskip) 0.0 plus 1.0fil
...\glue 0.0 plus 1.0fil
...\glue -5.0
...\glue 0.0 plus 1.0fil
...\glue 0.0
..\pdfliteral page <lua data reference ...>
..\pdfliteral page <lua data reference ...>
..\pdflinkstate 1
..\glue(\baselineskip) 18.8505
..\hbox(6.44444+0.0)x345.0, direction TLT
...\hbox(6.44444+0.0)x345.0, glue set 170.0fil, direction TLT
....\glue 0.0 plus 1.0fil
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/m/n/10 1
....\glue 0.0 plus 1.0fil
..\pdfliteral page <lua data reference ...>
..\pdfliteral page <lua data reference ...>
..\pdflinkstate 0
.\kern0.0
.\pdfliteral page <lua data reference ...>
Completed box being shipped out [2]
\vbox(627.36243+0.0)x434.0, direction TLT
.\hbox(0.0+0.0)x0.0, direction TLT
..\kern-72.26999
..\vbox(0.0+0.0)x0.0, glue set 72.26999fil, direction TLT
...\kern-72.26999
...\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\latelua0{ltx.__pdf.backend_ThisPage_gpush(tex.count["g_shipout_readonly_int"])}
....\glue 0.0 plus 1.0fil minus 1.0fil
...\glue 0.0 plus 1.0fil minus 1.0fil
.\glue 22.0
.\vbox(605.36243+0.0)x345.0, shifted 89.0, direction TLT
..\vbox(12.0+0.0)x345.0, glue set 12.0fil, direction TLT
...\glue 0.0 plus 1.0fil
...\pdflinkstate 1
...\hbox(0.0+0.0)x345.0, direction TLT
....\hbox(0.0+0.0)x345.0, direction TLT
...\pdflinkstate 0
..\glue 18.06749
..\glue(\lineskip) 0.0
..\vbox(550.0+0.0)x0.0, glue set 540.0fil, direction TLT
...\glue(\topskip) 10.0
...\hbox(0.0+0.0)x0.0, direction TLT
...\glue 0.0 plus 1.0fil
...\glue 0.0
..\pdflinkstate 1
..\glue(\baselineskip) 25.29494
..\hbox(0.0+0.0)x345.0, direction TLT
...\hbox(0.0+0.0)x345.0, direction TLT
..\pdflinkstate 0
.\kern0.0
.\pdfliteral page <lua data reference ...>
Chapter 1.
Completed box being shipped out [3]
\vbox(627.36243+0.0)x380.0, direction TLT
.\hbox(0.0+0.0)x0.0, direction TLT
..\kern-72.26999
..\vbox(0.0+0.0)x0.0, glue set 72.26999fil, direction TLT
...\kern-72.26999
...\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\latelua0{ltx.__pdf.backend_ThisPage_gpush(tex.count["g_shipout_readonly_int"])}
....\glue 0.0 plus 1.0fil minus 1.0fil
...\glue 0.0 plus 1.0fil minus 1.0fil
.\glue 22.0
.\vbox(605.36243+0.0)x345.0, shifted 35.0, direction TLT
..\vbox(12.0+0.0)x345.0, glue set 12.0fil, direction TLT
...\glue 0.0 plus 1.0fil
...\pdflinkstate 1
...\hbox(0.0+0.0)x345.0, direction TLT
....\hbox(0.0+0.0)x345.0, direction TLT
...\pdflinkstate 0
..\glue 18.06749
..\glue(\lineskip) 0.0
..\vbox(550.0+0.0)x345.0, glue set 360.83557fil, direction TLT
...\write-{}
...\write1{\@writefile{toc}{\protect \contentsline {chapter}{\protect \numberline {1} Chapter ] }{\thepage }{chapter.1}\protected@file@percent }}
...\marks1{\__mark_id:n {3}\MakeUppercase []{Chapter\ 1. \ Chapter ] }}
...\marks2{\__mark_id:n {4}}
...\mark{{\MakeUppercase []{Chapter\ 1. \ Chapter ] }}{}}
...\write1{\@writefile{lof}{\protect \addvspace {10\p@ }}}
...\write1{\@writefile{lot}{\protect \addvspace {10\p@ }}}
...\glue(\topskip) 10.0
...\rule(0.0+0.0)x*
...\penalty 10000
...\glue 50.0
...\glue 0.0
...\glue(\parskip) 0.0 plus 1.0
...\glue(\parskip) 0.0
...\glue(\baselineskip) 10.59724
...\hbox(14.40276+4.03276)x345.0, glue set 242.1882fil, direction TLT
....\localpar
.....\localinterlinepenalty=0
.....\localbrokenpenalty=0
.....\localleftbox=null
.....\localrightbox=null
....\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/bx/n/20.74 C
....\OT1/cmr/bx/n/20.74 h
....\OT1/cmr/bx/n/20.74 a
....\OT1/cmr/bx/n/20.74 p
....\discretionary (penalty 50)
.....< \OT1/cmr/bx/n/20.74 -
....\OT1/cmr/bx/n/20.74 t
....\OT1/cmr/bx/n/20.74 e
....\OT1/cmr/bx/n/20.74 r
....\TU/lmr/m/n/10
....\glue(\spaceskip) 4.4475 plus 3.88875 minus 2.5925
....\OT1/cmr/bx/n/20.74 1
....\penalty 10000
....\glue(\parfillskip) 0.0
....\glue(\rightskip) 0.0 plus 1.0fil
...\penalty 10000
...\glue 20.0
...\glue(\parskip) 0.0 plus 1.0
...\glue(\parskip) 0.0
...\glue(\baselineskip) 7.30724
...\hbox(18.66+6.22)x345.0, glue set 227.88545fil, direction TLT
....\localpar
.....\localinterlinepenalty=0
.....\localbrokenpenalty=0
.....\localleftbox=null
.....\localrightbox=null
....\hbox(0.0+0.0)x0.0, direction TLT
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/bx/n/24.88 C
....\OT1/cmr/bx/n/24.88 h
....\OT1/cmr/bx/n/24.88 a
....\OT1/cmr/bx/n/24.88 p
....\discretionary (penalty 50)
.....< \OT1/cmr/bx/n/24.88 -
....\OT1/cmr/bx/n/24.88 t
....\OT1/cmr/bx/n/24.88 e
....\OT1/cmr/bx/n/24.88 r
....\TU/lmr/m/n/10
....\glue(\spaceskip) 6.0 plus 4.665 minus 3.11
....\OT1/cmr/bx/n/24.88 ]
....\penalty 10000
....\glue(\parfillskip) 0.0
....\glue(\rightskip) 0.0 plus 1.0fil
...\penalty 10000
...\glue 40.0
...\glue(\parskip) 0.0 plus 1.0
...\glue(\parskip) 0.0
...\glue(\lineskip) 1.0
...\hbox(6.94444+0.0)x345.0, glue set 324.1666fil, direction TLT
....\localpar
.....\localinterlinepenalty=0
.....\localbrokenpenalty=0
.....\localleftbox=null
.....\localrightbox=null
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/m/n/10 S
....\OT1/cmr/m/n/10 t
....\OT1/cmr/m/n/10 u
....\OT1/cmr/m/n/10 ^^K (ligature ff)
....\penalty 10000
....\glue(\parfillskip) 0.0 plus 1.0fil
....\glue(\rightskip) 0.0
...\glue 0.0 plus 1.0fil
...\glue 0.0
..\pdfliteral page <lua data reference ...>
..\pdfliteral page <lua data reference ...>
..\pdflinkstate 1
..\glue(\baselineskip) 18.8505
..\hbox(6.44444+0.0)x345.0, direction TLT
...\hbox(6.44444+0.0)x345.0, glue set 170.0fil, direction TLT
....\glue 0.0 plus 1.0fil
....\pdfliteral page <lua data reference ...>
....\pdfliteral page <lua data reference ...>
....\OT1/cmr/m/n/10 3
....\glue 0.0 plus 1.0fil
..\pdfliteral page <lua data reference ...>
..\pdfliteral page <lua data reference ...>
..\pdflinkstate 0
.\kern0.0
.\kern-627.36243
.\hbox(0.0+0.0)x0.0, direction TLT
.\kern627.36243
.\pdfliteral page <lua data reference ...>
(test-gh725-opt-arg.aux)
Package tagpdf Info: Finalizing the tagging structure:
(tagpdf) Writing out ~18 structure objects
(tagpdf) with ~11 'MC' leaf nodes.
(tagpdf) Be patient if there are lots of objects!
Package tagpdf Info: writing ParentTree
Package tagpdf Info: writing IDTree
Package tagpdf Info: writing RoleMap
Package tagpdf Info: writing ClassMap
Package tagpdf Info: writing NameSpaces
Package tagpdf Info: writing StructElems
Package tagpdf Info: writing Root
15 changes: 15 additions & 0 deletions required/latex-lab/testfiles-sec/test-gh725-opt-arg.lvt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
\DocumentMetadata{
uncompress,
lang = en,
testphase = {phase-III}
}
\input{regression-test}

\documentclass{book}
\begin{document}
\START
\showoutput
\part{Part ]}
\chapter{ Chapter ] }
Stuff
\end{document}
Loading

0 comments on commit d508a8d

Please sign in to comment.