Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup firstaid #1108

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Cleanup firstaid #1108

merged 4 commits into from
Jul 19, 2023

Conversation

u-fischer
Copy link
Member

This removes three unneeded firstaids (everysel, bidi, memoir) from the firstaid file.

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added (not needed)
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included (imho unneeded in firstaid)
  • [ x] Relevant changes.txt updated
  • ltnewsX.tex (and/or latexchanges.tex) updated (imho unneeded)

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. The only thing I wonder is whether we want to keep the test (such as the one for bidi) or if we want to drop them too. Not sure.

@u-fischer
Copy link
Member Author

I thought we needed tests that the removal doesn't break something and the original firstaid tests would cover that.

@FrankMittelbach
Copy link
Member

I thought we needed tests that the removal doesn't break something and the original firstaid tests would cover that.

agreed, but those where I had commented out the code last time did already served their purpose :-) but I agree it might be better to keep them around ... I was just wondering if we want to keep them forever.

@u-fischer u-fischer merged commit 592f862 into develop Jul 19, 2023
68 checks passed
@u-fischer u-fischer deleted the cleanup-firstaid branch July 19, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants