Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise different errors for empty label and empty hook #1432

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Raise different errors for empty label and empty hook #1432

merged 2 commits into from
Sep 2, 2024

Conversation

muzimuzhi
Copy link
Contributor

See #1423.

  • New test cases are added to base/testfiles-lthooks/lthooks-errors.lvt.
  • Need rollback?
  • ltnews40 entry is added under section "Code improvements", rather than section "Bug fixes".

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

@josephwright
Copy link
Member

I feel we are OK here without rollback, but lets see what @FrankMittelbach thinks.

FrankMittelbach
FrankMittelbach approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, no rollback seems ok for that

@josephwright josephwright merged commit c46caf2 into latex3:develop Sep 2, 2024
42 checks passed
@muzimuzhi muzimuzhi deleted the fix/gh1423-empty-hook-error branch September 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephwright josephwright josephwright approved these changes

@FrankMittelbach FrankMittelbach FrankMittelbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muzimuzhi @josephwright @FrankMittelbach