Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard for #1495 #1510

Merged
merged 2 commits into from
Oct 28, 2024
Merged

guard for #1495 #1510

merged 2 commits into from
Oct 28, 2024

Conversation

davidcarlisle
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

The issue #1495 did not provide a test file, and I failed to generate one, however the existing code could clearly, if called at a bad time, hit TeX's \maxdimenmarker for\pagegoal` at the start of a page and lead to a dimension too large error,

It's possible this is a symptom of a logical flaw in the code, but this code has been widely publicised as a patch since around 2002 before being incorporated into the main release, so I do not want to do major changes without any test files.

This change restricts to adding a single guard to prevent \pagegoal being increased when it has the top of page value, so will have no effect except in cases that currently error. As such no rollback or test cases are added.

Copy link
Member

@josephwright josephwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One v. minor formatting issue - we can tidy after a merge


* longtable.dtx Guard against increasing \pagegoal past \maxdimen (gh/1495)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray line ....

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltnews entry perhaps?

@davidcarlisle
Copy link
Member Author

ltnews entry perhaps?

I could do if we want but I thought not, especially as I couldn't really say when this could occur, at the level of ltnews couldn't really say much more than "made a change to address gh1495" which isn't really very informative.

@davidcarlisle
Copy link
Member Author

ltnews entry perhaps?

I added a line

@josephwright josephwright merged commit b1e172c into develop Oct 28, 2024
72 of 84 checks passed
@josephwright josephwright deleted the gh1495 branch October 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants