guard for #1495 #1510
Merged
guard for #1495 #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephwright
approved these changes
Oct 28, 2024
|
|
||
| * longtable.dtx Guard against increasing \pagegoal past \maxdimen (gh/1495) | ||
|
|
||
|
|
FrankMittelbach
approved these changes
Oct 28, 2024
I could do if we want but I thought not, especially as I couldn't really say when this could occur, at the level of ltnews couldn't really say much more than "made a change to address gh1495" which isn't really very informative. |
I added a line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updatedThe issue #1495 did not provide a test file, and I failed to generate one, however the existing code could clearly, if called at a bad time, hit TeX's
marker for\pagegoal` at the start of a page and lead to a dimension too large error,It's possible this is a symptom of a logical flaw in the code, but this code has been widely publicised as a patch since around 2002 before being incorporated into the main release, so I do not want to do major changes without any test files.
This change restricts to adding a single guard to prevent
\pagegoalbeing increased when it has the top of page value, so will have no effect except in cases that currently error. As such no rollback or test cases are added.