-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended math options for luamml #1511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One v. minor formatting thing that we can skip - otherwise I think good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a number of suggestions and a few queries, some of which shoulf get resolved first (I guess)
% true it falls back to |equation*| and then errors because this can't find the end. | ||
% \end{itemize} | ||
% | ||
% true it falls back to |equation*| and then errors because this can't find the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an issue open for this bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I'm not sure if the bug is still there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then maybe, dropping it after checking :-)
% \item All (registered) environments grab their body | ||
% regardless of the state of the boolean. For | ||
% |equation|, |equation*| and |math| this is a change as they no longer can | ||
% |equation|, |equation*| and |math| this is a change as they no longer can | ||
% contain verbatim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something to consider perhaps for the future: have a "fragile" key (like beamer has) to switch grabbing so slow (token by token) grabbing, in which a \verb is recognized and then special grabbing code is is used for that. I realize I'm handwaving here. Any thoughts anybody, @josephwright?
@@ -218,62 +219,62 @@ | |||
% \item |tagsupport/math/struct/begin| This calls \cs{tag_struct_begin:n}. | |||
% It should also write the associated files if needed. | |||
% \item |tagsupport/math/substruct/begin| this handles subparts. | |||
% TODO: does it really make sense in inline math to have that?? | |||
% TODO: does it really make sense in inline math to have that?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean subparts as part of some inline math? Sounds dubious to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I mean, I don't think that makes much sense in inline math.
% It means that if one wants to reenable math processing inside some (fake) math | ||
% one has to do it after \cs{m@th} calls. | ||
% \end{itemize} | ||
% | ||
% | ||
% Open problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should that be some sort of a heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, but made it into one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure either, but it looked like it might be better one.
The PR corrects the setting of the Alt key in equations and adds support for the structelem variant with lualatex. The documentation has been extended.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updated.