Skip mapping over undeclared prop in \ShowHook etc.
#1515
Merged
+55
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzimuzhi
force-pushed
the
fix/gh1513-ShowHook
branch
from
dfdfa13
to
82bd1a2
Compare
josephwright
requested changes
Oct 29, 2024
FrankMittelbach
approved these changes
Oct 29, 2024
Comment on lines
+6189
to
+6190
| { ! \prop_if_exist_p:c { g_@@_#1_code_prop } } | ||
| { \prop_if_empty_p:c { g_@@_#1_code_prop } } |
There was a problem hiding this comment.
actually, it might be worth putting in a short comment why this is necessary, ie that a non-existent prop would return "empty" = true but that fail when mapping over it
There was a problem hiding this comment.
rubbish, would be empty = false ....
josephwright
added
fixed in dev
josephwright
added a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not so familiar with hooks implementation, so maybe there're more uncaught similar cases.
Rollback needed? Only
\ShowHook,\LogHookand friends are affected.ltnews40.texentry not added. Maybe after #1512 gets merged?Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated