Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows binaries #458

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: add windows binaries #458

merged 2 commits into from
Oct 23, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Oct 23, 2024

Customer requests Windows builds of Relay.

Looks like the test run was successful: https://github.com/launchdarkly/ld-relay/releases/tag/v8.10.0-beta.1

  • sanity check run the binary on Windows

BEGIN_COMMIT_OVERRIDE
fix(build): add windows binaries
END_COMMIT_OVERRIDE

@cwaldren-ld cwaldren-ld marked this pull request as ready for review October 23, 2024 19:28
@cwaldren-ld cwaldren-ld requested a review from a team as a code owner October 23, 2024 19:28
.goreleaser.yml Outdated
@@ -11,6 +11,7 @@ builds:
goos: # Goreleaser's default for this is darwin + linux, but let's be explicit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment could use updated now.

@cwaldren-ld cwaldren-ld changed the title build: add windows binaries feat: add windows binaries Oct 23, 2024
@cwaldren-ld cwaldren-ld merged commit 388feb4 into v8 Oct 23, 2024
10 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/sdk-807-windows branch October 23, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants