Reverted to v3.1.0

laurentpayot · Apr 14, 2023 · 00c9694 · 00c9694
1 parent 4cf3084
commit 00c9694
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Minidenticons changelog
 
+## 3.1.2
+
+_2023-04-14_
+
+### New features
+
+- Reverted to v3.1.0 (custom element size optimization was canceling v3 performance gain)
+
 ## 3.1.1
 
 _2023-04-14_

diff --git a/README.md b/README.md
@@ -31,7 +31,7 @@ Minidenticons uses [ES modules](https://jakearchibald.com/2017/es-modules-in-bro
 
 ```html
 <script type="module">
-  import { identiconSvg } from 'https://cdn.jsdelivr.net/npm/minidenticons@3.1.1/minidenticons.min.js'
+  import { identiconSvg } from 'https://cdn.jsdelivr.net/npm/minidenticons@3.1.2/minidenticons.min.js'
 </script>
 ```
 

diff --git a/minidenticons.js b/minidenticons.js
@@ -47,11 +47,13 @@ export const identiconSvg =
             static observedAttributes = ['username', 'saturation', 'lightness']
             // private fields to allow Terser mangling
             static #memoized = {}
-            connectedCallback() { this.#setContent() }
-            // attributeChangedCallback() is called for every observed attribute before connectedCallback()
-            attributeChangedCallback(name, oldValue, newValue) {
-                if (oldValue !== newValue) this.#setContent()
+            #isConnected = false
+            connectedCallback() {
+                this.#setContent()
+                this.#isConnected = true
             }
+            // attributeChangedCallback() is called for every observed attribute before connectedCallback()
+            attributeChangedCallback() { if (this.#isConnected) this.#setContent() }
             #setContent() {
                 const args = IdenticonSvg.observedAttributes
                                 .map(key => this.getAttribute(key) || undefined)

diff --git a/minidenticons.min.js b/minidenticons.min.js
diff --git a/minidenticons.min.js.map b/minidenticons.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "minidenticons",
-  "version": "3.1.1",
+  "version": "3.1.2",
   "description": "Super lightweight SVG identicon (icon avatar) generator",
   "author": "Laurent Payot",
   "license": "MIT",