Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkgconfig to find glib #520

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

nosracd
Copy link
Contributor

@nosracd nosracd commented Jul 19, 2024

This PR implements the changes described and motivated in this comment.

@nosracd nosracd requested a review from ihilt July 19, 2024 14:19
@nosracd nosracd mentioned this pull request Jul 19, 2024
@ihilt
Copy link
Contributor

ihilt commented Jul 19, 2024

In my opinion, this is an improvement since it permits pkg-config to supply the library paths rather than relying on CMake to search only standard paths. This is particularly relevant for systems where libraries are in non-standard locations, e.g. Nix.

@nosracd nosracd requested a review from tprk77 July 19, 2024 15:08
@tprk77
Copy link
Member

tprk77 commented Jul 19, 2024

I'm going to reply in the original thread.

@nosracd nosracd mentioned this pull request Jul 19, 2024
fall back to old behavior if pkgconfig itself cannot be found or if pkgconfig cannot find glib
@nosracd nosracd force-pushed the refactor/find_glib_with_pkgconfig branch from 00fe2c6 to 742dbbb Compare July 26, 2024 19:24
@nosracd
Copy link
Contributor Author

nosracd commented Jul 28, 2024

In a separate thread @tprk77 indicated he was good with this approach.

@nosracd nosracd merged commit c40e842 into lcm-proj:master Jul 28, 2024
11 checks passed
@nosracd nosracd deleted the refactor/find_glib_with_pkgconfig branch July 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants