-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lcm-logger: New --disk-quota
flag
#529
base: master
Are you sure you want to change the base?
Conversation
Exit logger when target disk is almost filled up.
lcm-logger/lcm_logger.c
Outdated
// @Review: How should this exit? For now going with a graceful exit. | ||
// But maybe this case warrants more urgency. | ||
g_main_loop_quit(_mainloop); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current approach is ideal. If the user sets up a condition for the logger to end then a non-zero exit code makes sense to me, since everything is operating as expected. But I don't feel strongly at all about it.
* Fix macos * improve help * Instant exit on known failed quota
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a couple notes:
- There are still a few
@Review
in-code comments, but I believe I already replied to them or they appear to be notes to self. Can they be removed? - There's also a man pages document (
lcm-logger/lcm-logger.1
) that should be updated when the UX changes. This wouldn't be the first thing that caused those documents to go out of sync so I think it's fine to fix it either here or later in Update man pages #537.
Fix #464
Currently put the check in the write thread and does not cause an immediate
exit(1)
. Please review.