Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf to 3.0.0 #1567

Closed
wants to merge 2 commits into from
Closed

Conversation

hchan10
Copy link

@hchan10 hchan10 commented Jul 20, 2023

  • Regenerate new protobuf files

  • Resolve issues caused by the protobuf update

* Regenerate new protobuf files

* Resolve issues caused by the protobuf update
@docs-page
Copy link

docs-page bot commented Jul 20, 2023

To view this pull requests documentation preview, visit the following URL:

patrol.leancode.co/~1567

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added the package: patrol Related to the patrol package (native automation, test bundling) label Jul 20, 2023
* Resolve issue caused by the protobuf update
@bartekpacia
Copy link
Contributor

bartekpacia commented Jul 21, 2023

Thanks for the PR!

I'd like to do it but for now, we've gotta support Flutter 3.3 and Flutter 3.7.

Also, the fact that the generated API changed so much (Selector(text: 'hey') -> Selector..text = 'hey') will probably mean we'll have to add some compatibility code by hand. We don't want breaking changes because of a dependency update.

@shilangyu
Copy link
Contributor

After a backlash from this change in generation (making migration extremely tedious and result in worse code), they are working on adding a flag to restore the old behavior: google/protobuf.dart#855. Probably worth to wait for it?

@bartekpacia
Copy link
Contributor

bartekpacia commented Aug 7, 2023

Thanks for info @shilangyu, I'm happy they're bringing back the old syntax. Let's wait.

@bartekpacia
Copy link
Contributor

google/protobuf.dart#855 is done, but we're blocked because its newewst version requires Dart 2.19, and our current min is Dart 2.18 (from Flutter 3.3).

@bartekpacia
Copy link
Contributor

Thank you for the contribution, but we decided to ditch protobufs and gRPC in #1567.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants