Use stable release for bootstrapping #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuisi
changed the title
|
I did some manual testing and it seems to work as expected. |
Kha
approved these changes
Sep 8, 2023
| } | ||
| const release_match = /^leanprover\/lean4:(\d+)-(\d+)-(\d+)$/.exec(toolchainVersion); | ||
| if (release_match) { | ||
| return new Date(2023, 9, 8); |
There was a problem hiding this comment.
Oof. Is it time to get rid of the Lake conditional?
There was a problem hiding this comment.
I think it's a good idea to get rid of it eventually, though not in this PR. I'm not sure about the ways in which people might acquire very old setups, so perhaps it's better to leave it in for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the bootstrapping to load Lean 4 stable instead of Lean 4 nightly in preparation for the first release. It should not be merged before the release is out. I also need to do some additional QA after the release and before merging, as this is currently entirely untested.