Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer columns order #626

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Explorer columns order #626

merged 2 commits into from
Nov 25, 2024

Conversation

TdyP
Copy link
Contributor

@TdyP TdyP commented Nov 22, 2024 •
edited
Loading

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel 
     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

@TdyP TdyP changed the title Exploer columns order Explorer columns order Nov 22, 2024
@TdyP TdyP force-pushed the feature/XSTREAM-953_columnsOrderClean branch from 7c7f926 to b952bd2 Compare November 22, 2024 10:57
P0ppoff
P0ppoff approved these changes Nov 22, 2024
View reviewed changes
docs/adr/ADR.md Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/ColumnItem.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/ColumnItem.tsx Show resolved Hide resolved
libs/ui/src/locales/fr/shared.json Outdated Show resolved Hide resolved
docs/adr/ADR-001-dnd.md Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/edit-settings.test.tsx Show resolved Hide resolved
@TdyP TdyP force-pushed the feature/XSTREAM-953_columnsOrderClean branch from b952bd2 to 55477e1 Compare November 22, 2024 15:22
@TdyP TdyP merged commit fa687e8 into develop Nov 25, 2024
25 checks passed
@TdyP TdyP deleted the feature/XSTREAM-953_columnsOrderClean branch November 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evoiron evoiron evoiron approved these changes

@P0ppoff P0ppoff P0ppoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TdyP @P0ppoff @evoiron