chore: devcontainer

leehanchung · Sep 11, 2023 · 37130ce · 37130ce
1 parent 7a2be0a
commit 37130ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,15 +1,6 @@
 {
   "name": "llm-pdf-qa-workshop",
   "image": "mcr.microsoft.com/vscode/devcontainers/python:3.10-bullseye",
-  // Couldnt get github mounts to work. perhaps need to set that inside Dockerfile?
-  // "build": {
-  //   "dockerfile": "../Dockerfile",
-  //   "args": {
-  //     "VARIANT": "3.10-bullseye",
-  //     "POETRY_VERSION": "1.6.1"
-  //   }
-  // },
-  // "remoteUser": "root",
   "features": {
     "ghcr.io/devcontainers-contrib/features/pre-commit:2": {
       "version": "latest"
@@ -18,7 +9,7 @@
   "mounts": [
     // Re-use local git and ssh configurations. On container its at /workspaces/vscode
     "source=${env:HOME}/.gitconfig,target=/home/vscode/.gitconfig,type=bind",
-    "source=${env:HOME}/.ssh,target=//home/vscode/.ssh,type=bind"
+    "source=${env:HOME}/.ssh,target=/home/vscode/.ssh,type=bind"
   ],
   "postCreateCommand": ".devcontainer/post_create_command.sh",
   "postStartCommand": "git config --global --add safe.directory ${containerWorkspaceFolder}",

diff --git a/.devcontainer/post_create_command.sh b/.devcontainer/post_create_command.sh
@@ -2,9 +2,9 @@
 set -euf -o pipefail
 IFS=$'\n\t'
 
-# install poetry
+# Install poetry
 curl -sSL https://install.python-poetry.org | python3 -
 
-# create python virtual environment
+# Create python virtual environment
 poetry install --no-root
 poetry shell