Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation for interested developers #496

Merged
merged 7 commits into from
Sep 24, 2023

Conversation

JVT038
Copy link
Collaborator

@JVT038 JVT038 commented Sep 7, 2023

No description provided.

@JVT038
Copy link
Collaborator Author

JVT038 commented Sep 13, 2023

@leepeuker There are two things that still need proper explanation / documentation before I can mark this as 'ready for review' and merge it.

Could you add the explanation about for the /src/Domains directory (just say what the directory is and what it's meant for) and explain how the dependency injection / bootstrapping works?

@leepeuker
Copy link
Owner

I have adjusted the text at a few places and added an explanation for the /src/Domains directory

@leepeuker
Copy link
Owner

@JVT038 I would be fine with it like this for a first version. If you agree and my additions are understandable you can merge this

@leepeuker leepeuker marked this pull request as ready for review September 24, 2023 13:27
@leepeuker leepeuker self-requested a review as a code owner September 24, 2023 13:27
@JVT038 JVT038 merged commit 87944d1 into main Sep 24, 2023
1 check passed
@leepeuker leepeuker deleted the add-developer-documentation branch September 26, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants