Move webhook endpoints to the REST API #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the webhook payload also be added to the openapi specs? |
Hm, good question. I guess we could document what we really use from the payload (instead of everything the webhhook source provides). On the other site, documenting it would make it easier for people to use the webhook endpoints for other stuff and I do not think I would like to support this. The webhooks are depended on what the third party sends to us and not on how we would like it. |
leepeuker
reviewed
Sep 30, 2023
leepeuker
reviewed
Sep 30, 2023
leepeuker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the webhooks to the API group instead of web.
Should the other webhook-related functions (such as deleting a webhook URL and regenerating an URL) be moved to the API group as well?