Support vault prefix depth config (#73) #74
Conversation
|
Hey @davidsloan 👋, would be great if you could have a look. We are currently facing issues resolving secrets from vault engines with prefix path depth > 1. I also think the codacy check has to be adapted so it allows |
| @@ -324,6 +324,27 @@ class VaultSecretProviderTest extends AnyWordSpec with Matchers with BeforeAndAf | |||
| response.getData.asScala("value") shouldBe "mock" | |||
| } | |||
|
|
|||
| "should be configured for vault engine prefix depth" in { | |||
There was a problem hiding this comment.
there is a test for explicitly setting the prefix depth, can there also be a test to ensure the default value is 1?
There was a problem hiding this comment.
I also added a test for the default 👍
There was a problem hiding this comment.
@davidsloan Does this look good to you?
keejon
force-pushed
the
feat/support-vault-prefix-path-depth
branch
from
169dad3
to
d45e27e
Compare
|
Hey @davidsloan, sorry to bother you again but would you be able to merge this and ideally make an release? Would be greatly appreciated 🙏 |
|
Hi @keejon , It will take a while for us to release it since we need to upgrade the Kafka dependencies and investigate the CVEs. We advise to build the project and use the artifacts before we release them. |
The Vault Secret Provider seems to have problems to retrieve secrets from KV secret engines with a path that is longer than one element (e.g. secrets/dev). This will make the prefix path depth of the vault client configurable. (#73)