[show_model_with_bounding] fix issue #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoaShapira8
requested review from
leondavi,
ohad123 and
GuyPerets106
as code owners
|
@NoaShapira8 |
leondavi
requested changes
Jul 14, 2024
| @@ -8,7 +8,7 @@ | |||
| LayerTypeMap = OrderedDict([ | |||
| ("Default" , "0"), | |||
| ("Scaling" , "1"), | |||
| ("Conv" , "2"), | |||
| ("CNN" , "2"), | |||
There was a problem hiding this comment.
Why do you change conv layer to CNN?
Conv is the correct name of convolutional layer.
leondavi
requested changes
Jul 14, 2024
| @@ -81,7 +81,9 @@ | |||
| ("Probabilistic" , ProbabilisticActivationFunctionMap), | |||
| ("LSTM" , None), | |||
| ("Reccurrent" , None), | |||
| ("Unscaling" , UnScalingMethodMap)] | |||
| ("Unscaling" , UnScalingMethodMap), | |||
| ("Flatten" , FlattenMethodMap), | |||
There was a problem hiding this comment.
@Orisadek
You should validate that Flatten and Bounding are supported by parser and NerlWorkerNN
leondavi
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.