fixed bug in import subpath module #4236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @iChenLei can you plz check this pr ? and merge it under hacktoberfest |
|
@matthew-dean hi is everything ok this this pr ? if no plz tell me what's wrong and how to fix it |
|
Without any tests added to this PR, proving the issue and proving that this fix fixes it, I don't see how this can be merged. |
can you put it in test? i don't know how to test it. but seems it fixed the issue |
|
@matthew-dean hi can you plz provide any feedback ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: i fixed this issue : #3715
Why: with this changes the issue get fixed.
Checklist: