-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'TagString' test #1319
base: master
Are you sure you want to change the base?
Added 'TagString' test #1319
Conversation
It looks like the test you've added is failing with the following error: expected tag string representation: Tag(time=$time, microstep=$microstep), instead got: {tag_str} Do you know why that might be? |
This seems to be because the python target submodule wasn't updated. The git history is a bit messy now but I just updated so the test should pass. Also, thanks to your comment I noticed a formatting error in the error message, which I fixed as well. |
Ah I see.
No worries. We an squash the commits. Thanks for adding this feature! |
@patilatharva: I looks like this PR has been under the radar for a while. Shall we bring it back into a state to where we can merge it? One issue with this PR is that I don't quite understand what it attempts to do, so if you could update the description to clarify, that would be a great first step. Thanks, and sorry for the delayed handling of this! |
Yes, thanks for bringing this back to my attention! I'll make it ready for review. |
This test ensures tag objects have the string representation: Tag(time=$time, microstep=$microstep)