Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled C federated tests with Rust RTI #2211

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chanijjani
Copy link
Collaborator

@chanijjani chanijjani commented Feb 19, 2024

@chanijjani
Copy link
Collaborator Author

chanijjani commented Feb 19, 2024

I want to set a label, but I can't configure it. Could anyone help me enable it?

@lhstrh lhstrh added federated feature New feature labels Feb 20, 2024
@lhstrh
Copy link
Member

lhstrh commented Feb 20, 2024

Terrific to see progress on this front, @chanijjani! It's encouraging that you've been able to get things to work, but the way managed to do it, by introducing a new target and replicating tests, is not quite the right approach.

But perhaps we should not focus on that and instead review your RTI implementation? We can help with the integration at a later point...

@chanijjani
Copy link
Collaborator Author

chanijjani commented Feb 20, 2024

@lhstrh Thank you so much for adding labels to this PR.
I agree that the granularity of the new target needs to be revised and balanced with existing targets. The primary purposes of this PR are to see whether it passes all existing CI tests since I experienced just two failures in my forked repository and to get some comments to set the future directions of Rust RTI tests correctly. The merging of this PR is optional to me. We may merge this content (C federated tests with Rust RTI) if I make a new PR based on the correct way of integration later.
So.. Any reviews and comments are welcome!

@chanijjani chanijjani force-pushed the rust-rti-test branch 2 times, most recently from 33b6d62 to c216605 Compare February 21, 2024 06:27
- At first, thirty-four C federated tests are evaluated with Rust RTI
@chanijjani chanijjani force-pushed the rust-rti-test branch 3 times, most recently from 48de675 to c2cf4ac Compare February 25, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants