Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ccip reverse resolving #27

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Apr 11, 2024

Close #26

This PR adds a hint argument to address_to_domain and set_address_to_domain

Note : it will require

  • updating the different libs that use address_to_domain: starknetid.js, starknet-react and starknet.js
  • updating externalDomainActions component & solanaCalls to set as main domain in the app to add an additional hint parameter & add support for CCIP external domains.

@irisdv irisdv requested a review from Th0rgal April 11, 2024 08:06
@irisdv irisdv added the 🔥 Ready for review Pull Request needs a label Apr 11, 2024
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit 5feac34 into master Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hint support to address_to_domain
2 participants