Test using prvalues vs. lvalue or temporary.

libbitcoin · Jun 11, 2024 · 871f628 · 871f628
1 parent dcef21c
commit 871f628
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/bitcoin/database/impl/query/archive.ipp b/include/bitcoin/database/impl/query/archive.ipp
@@ -88,8 +88,8 @@ inline bool CLASS::is_malleated64(const block& block) const NOEXCEPT
 
     // Pass l-value to iterator.
     // block.get_hash() assumes cached or is not thread safe.
-    const auto link = to_header(block.get_hash());
-    auto it = store_.txs.it(link);
+    ////const auto link = to_header(block.get_hash());
+    auto it = store_.txs.it(to_header(block.get_hash()));
     if (!it)
         return false;
 

diff --git a/test/query/validate.cpp b/test/query/validate.cpp
@@ -364,8 +364,8 @@ BOOST_AUTO_TEST_CASE(query_validate__get_tx_state__connected_in_context__tx_conn
     BOOST_REQUIRE(query.set_tx_connected(2, { 1, 5, 9 }, 15, 16));
     BOOST_REQUIRE(query.set_tx_connected(2, { 2, 6, 0 }, 17, 18));
     BOOST_REQUIRE(query.set_tx_connected(3, ctx, 19, 20));
-    BOOST_REQUIRE_EQUAL(query.get_tx_state(2, ctx), error::tx_connected);
-    BOOST_REQUIRE_EQUAL(query.get_tx_state(fee, sigops, 2, ctx), error::tx_connected);
+    BOOST_REQUIRE_EQUAL(query.get_tx_state(tx_link{ 2 }, ctx), error::tx_connected);
+    BOOST_REQUIRE_EQUAL(query.get_tx_state(fee, sigops, tx_link{ 2 }, ctx), error::tx_connected);
     BOOST_REQUIRE_EQUAL(fee, expected_fee);
     BOOST_REQUIRE_EQUAL(sigops, expected_sigops);
 }