Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the option to use an external pool in MessageDispatcher #137

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

damcaoson
Copy link
Contributor

Hi, as the title suggests, it would be helpful if the MessageDispatcher could take an external pool as a parameter, instead of always using the static pool. This is especially useful in parallel messaging situations, as I mentioned in #120.

@davebaol
Copy link
Member

Looks good to me. Only I don't like upper case letters for member variable POOL.

@damcaoson
Copy link
Contributor Author

I don't prefer the uppercase POOL either. I left it unchanged because I didn't want to alter the git annotation for such a small change. But since you don't like it, I'll update it to lowercase.

@davebaol
Copy link
Member

@damcaoson Thanks

@Tom-Ski or any other maintainer. I cannot remember where the build server is. So please, send me this info or merge this PR yourself if the remote build succeeds. Thanks 😄

@Tom-Ski
Copy link
Member

Tom-Ski commented Sep 30, 2024

@davebaol think we will migrate this to GHA, because we are doing that everywhere else.

@Tom-Ski
Copy link
Member

Tom-Ski commented Oct 1, 2024

@davebaol ok it should be setup now. Snapshots are deploying on commits to master. GH release is tied to a real maven release, so you can trigger it from here by making a new release on GH. (Version info is now in gradle.properties, so thats where you increment)

Also added auto running on PR's so it will build and also run your unit test suite. Let me know if any issues!

@davebaol
Copy link
Member

davebaol commented Oct 1, 2024

@Tom-Ski Great, thanks.

@davebaol davebaol merged commit 6726e34 into libgdx:master Oct 1, 2024
1 check passed
@hw207165
Copy link

Any release plan for this MR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants