Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't use Cronet directly for downloading #6887

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Dec 18, 2024

  • this allows to remove Cronet as per [meta] drop cronet #6867 or make it optional, depending on the state of the discussion
  • apart from this, the refactor here has been needed for a long time to make the download service more comprehensive
  • using OkHttp instead of a HttpUrlConnection instance directly allows us to act on a higher level, the HTTP client might also fix some issues experienced by users, for instance it automatically retries to connect if the connection fails

possibly resolves #5661

@Bnyro Bnyro merged commit 9f5aab4 into libre-tube:master Dec 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Exception
1 participant