Avoid calling strlcpy when copying string onto itself (#17031)

libretro · Sep 25, 2024 · 10a1154 · 10a1154
1 parent c90f7ab
commit 10a1154
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/gfx/video_shader_parse.c b/gfx/video_shader_parse.c
@@ -3033,8 +3033,9 @@ bool video_shader_apply_shader(
          configuration_set_bool(settings, settings->bools.video_shader_enable, true);
          if (!string_is_empty(preset_path))
          {
-            strlcpy(runloop_st->runtime_shader_preset_path, preset_path,
-                  sizeof(runloop_st->runtime_shader_preset_path));
+            if (runloop_st->runtime_shader_preset_path != preset_path)
+               strlcpy(runloop_st->runtime_shader_preset_path, preset_path,
+                     sizeof(runloop_st->runtime_shader_preset_path));
 #ifdef HAVE_MENU
             /* reflect in shader manager */
             if (menu_shader_manager_set_preset(