Add an environment call for querying the device's battery #15387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libretro-common/include/libretro.h # runloop.c
- I misunderstood the meaning of these enums
- Don't return 0 seconds; instead, return NO_ESTIMATE - Don't force percent to 100 in the CHARGED state
|
@LibretroAdmin @barbudreadmon (since you've added callbacks before) Anyone else? This looks pretty straightforward to me. |
|
It looks fine to me |
RobLoach
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
I believe this is working well. Tried adding it to ChaiLove in libretro/libretro-chailove#424 ....
var powerInfo = love.system.getPowerInfo()
print("Battery")
print(to_string(powerInfo.state))
print(to_string(powerInfo.seconds))
print(to_string(powerInfo.percent))
Battery
3
-1
-1
|
@LibretroAdmin Any objections to merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new environment callback that allows cores to query the frontend's battery level and power status. This can be useful for emulating battery life on handheld game consoles such as the Nintendo DS. Another possible use case is to allow cores to reduce their workload if the battery is low.
RetroArch already implements this functionality in a cross-platform manner. I just expose it to cores.
Note that this PR has not been tested yet; I intend to test it on a core I'm working on in the near future. Right now I'm gathering feedback and declaring my intent to get this merged at some point. Once I integrate this into my core, I will consider it ready to be merged.Okay, I tested it. Works like a charm. https://cdn.discordapp.com/attachments/876520593636335646/1131628490148560988/20230720_124448.mp4