Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rwebaudio freezing bug #15449

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Fix rwebaudio freezing bug #15449

merged 1 commit into from
Jul 2, 2023

Conversation

ethanaobrien
Copy link
Contributor

Guidelines

  1. Rebase before opening a pull request
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises

Description

This PR fixes the bug thought to be fixed in #15442. Turns out, the issue is actually a race condition. The reason why #15442 seemed to fix the issue was because adding another buffer gave the browser more time to initialize (aka, the whole thing was a race condition) This was simply fixed by calling the function to set the start time if not already set, so the entire page doesn't get stuck in an endless loop (since javascript only has 1 thread).

Related Issues

See EmulatorJS/EmulatorJS#416

Related Pull Requests

Originally thought to be fixed in #15442.

@LibretroAdmin LibretroAdmin merged commit 58aafee into libretro:master Jul 2, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants