Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "wayland: Commit viewport resizes (#16419)" #17026

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Revert "wayland: Commit viewport resizes (#16419)" #17026

merged 1 commit into from
Sep 23, 2024

Conversation

alphabitserial
Copy link
Contributor

This reverts commit 08496b3 (#16419), fixing #17020.

@LibretroAdmin
Copy link
Contributor

I'll merge it for now.

@ColinKinloch Any thoughts on this?

@LibretroAdmin LibretroAdmin merged commit 3ee3f2a into libretro:master Sep 23, 2024
27 checks passed
@alphabitserial alphabitserial deleted the fix_wayland_crash branch September 23, 2024 06:48
@alphabitserial alphabitserial mentioned this pull request Sep 23, 2024
Closed
@alphabitserial
Copy link
Contributor Author

Happy to help test alternate approaches to solving the problem that motivated the original commit, just ping me.

@ColinKinloch
Copy link
Contributor

I've successfully reproduced it in a nested version of COSMIC (#17029).
I'll have to look into it more.
Here's a screenshot of it crashing.
Screenshot From 2024-09-23 16-18-01

ColinKinloch added a commit to ColinKinloch/RetroArch that referenced this pull request Sep 23, 2024
@ColinKinloch
Reapply "wayland: Commit viewport resizes (libretro#16419)" (libretro…
eff3468 
…#17026)

This reverts commit 3ee3f2a.

Removing roundtrips seems to keep things snappy whilst fixing COSMIC.
@ColinKinloch
Copy link
Contributor

@alphabitserial would you be able to test #17030.
It fixes the issue in a nested COSMIC compositor.

LibretroAdmin pushed a commit that referenced this pull request Sep 27, 2024
@ColinKinloch
Reapply "wayland: Commit viewport resizes (#16419)" (#17026) (#17030)
63bd0b7 
This reverts commit 3ee3f2a.

Removing roundtrips seems to keep things snappy whilst fixing COSMIC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alphabitserial @LibretroAdmin @ColinKinloch