Report replay frame number for active_replay stdout api #17039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the replay movie's frame_ptr (a 20-bit number used to point to a log of file offsets) into a frame counter, which is masked against the 20-bit pattern for use in the file offset log but also functions as a time index into the replay. Right now that is reported in `GET_CONFIG_PARAM active_replay` but in the future it could be used to show how far into the replay we are during playback or how long the replay is during recording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the replay movie's
frame_ptr(a 20-bit number used to point to a log of file offsets) into a frame counter, which is masked against the 20-bit pattern for use in the file offset log but also functions as a time index into the replay. Right now that is reported inGET_CONFIG_PARAM active_replaybut in the future it could be used to show how far into the replay we are during playback or how long the replay is during recording.