Use frame cache size in integer scaling instead of av info geometry #17057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since it is not guaranteed that cores output exactly at base size, using it in integer scaling calculation will not produce optimal results.
For example here with Mupen64 which outputs really at 640x240 instead of reported 640x480:
Huge borders without integer:
And for comparison integer not-overscaled:
Current integer overscale next step jumps badly overboard:
Fixed to use current cached frame size instead to get the missing step:
Are there any downsides to this that I'm not seeing?
Related Pull Requests
#17056