Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame cache size in integer scaling instead of av info geometry #17057

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

sonninnos
Copy link
Collaborator

Description

Since it is not guaranteed that cores output exactly at base size, using it in integer scaling calculation will not produce optimal results.

For example here with Mupen64 which outputs really at 640x240 instead of reported 640x480:

Huge borders without integer:
retroarch_2024_09_28_01_04_29_691

And for comparison integer not-overscaled:
retroarch_2024_09_28_01_14_25_444

Current integer overscale next step jumps badly overboard:
retroarch_2024_09_28_01_04_32_411

Fixed to use current cached frame size instead to get the missing step:
retroarch_2024_09_28_01_03_37_660

Are there any downsides to this that I'm not seeing?

Related Pull Requests

#17056

@LibretroAdmin LibretroAdmin merged commit 7cb1543 into libretro:master Sep 29, 2024
27 checks passed
@sonninnos sonninnos deleted the integer-scaling-size branch September 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants