[MERGED] udev: Update Nntendo Co., Ltd. Pro Controller (old).cfg to Nintendo Co., Ltd. Pro Controller (default-off).cfg
#1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…td. Pro Controller (default-off).cfg Added "(default-off)" to the file name. See https://github.com/libretro/docs/blob/119f15fb0b9ab92ec4b3a02976c1c0e907e35466/docs/guides/controller-autoconfiguration.md#default-off-configs
davidhedlund
changed the title
davidhedlund
changed the title
udev/Nintendo Co., Ltd. Pro Controller (old).cfg renamed to udev/Nintendo Co., Ltd. Pro Controller (default-off).cfg
Added top comments: # The file name was changed from "Nintendo Co., Ltd. Pro Controller.cfg" to "Nintendo Co., Ltd. Pro Controller (default-off).cfg": # - "(default-off)" indicates that the autoconfig file is not active by default. See comments for input_vendor_id and input_product_id.
* input_l_x_plus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. * input_r_x_plus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. * input_r_y_minus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed.
…Controller (default-off).cfg` Retroarch generates `Pro Controller.cfg` not `Nintendo Co., Ltd. Pro Controller.cfg` for udev
davidhedlund
changed the title
udev/Nintendo Co., Ltd. Pro Controller (old).cfg renamed to udev/Nintendo Co., Ltd. Pro Controller (default-off).cfgudev/Nintendo Co., Ltd. Pro Controller (old).cfg renamed to udev/Pro Controller (default-off).cfg
input_device = "Pro Controller"
added "(default-off)" to input_device_display_name = "Nintendo Switch Pro Controller (default-off)"
removed "(default-off)" from input_device_display_name
# Due to the uncommon nature of this device, the autoconfig file is not active by default. This precaution is taken to avoid potential conflicts with the widely-used Nintendo Switch Pro Controller (nintendo-hid version) file. Button layouts are not compatible. To activate this configuration: # 1) Comment out the input_vendor_id and input_product_id lines in the "Nintendo Co.,Ltd. Pro Controller.cfg" file. # 2) Uncomment the input_vendor_id and input_product_id lines below:
# This file uses the legacy controller name "Pro Controller" (generated by RetroArch on Linux 5.15) # "(default-off)" was added to the file name to indicate that the autoconfig file is not active by default. See comments for input_vendor_id and input_product_id.
davidhedlund
changed the title
udev/Nintendo Co., Ltd. Pro Controller (old).cfg renamed to udev/Pro Controller (default-off).cfgudev/Nintendo Co., Ltd. Pro Controller (old).cfg updated
# Comparison with other non-HID autoconfig versions for the left thumbstick functionality: # linuxraw/Pro Controller (default-off).cfg: Yes # sdl2/Pro Controller (default-off).cfg: Yes # udev/Pro Controller (default-off).cfg: No
davidhedlund
changed the title
udev/Nintendo Co., Ltd. Pro Controller (old).cfg updatedNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfg
# input_l_x_plus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. # input_r_x_plus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed. # input_r_y_minus_axis is manually defined here as RetroArch cannot auto-detect it due to Linux driver limitations. This setting may function if a compatible driver has been manually installed.
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfg
# This autoconfig file was generated using RetroArch via the Flathub package. # Please refrain from updating it with an autoconfig created by the AppImage: The SDL2 controller driver utilizes UDEV rather than SDL2 - hizzlekizzle/RetroArch-AppImage#12
wrong file, sorry
# The input_l_x_plus_axis is manually set here since RetroArch can't auto-detect it in Linux , but manual adjustments make it functional.
Removed thumb-stick status. it is working with all controller drivers when the thumb stick input variables have been added manually, I've tested them!
# The input_l_x_plus_axis is manually set here since RetroArch can't auto-detect it in Linux 5.15 if the controller is connected over BlueTooth, but manual adjustments make it functional.
# input_l_x_plus_axis is generated when the controller is connected via USB, but not via BlueTooth. However, it is working for both protocols.
The udev driver depends on input_device, rather than input_vendor_id and input_product_id.
udev automatically utilize the autoconfig file that corresponds to the name used by the active Linux kernel.
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller.cfg
# Remove input_vendor_id and input_product_id once this issue has been solved: [IMPORTANT] Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904 input_vendor_id = "1406" input_product_id = "8201"
Nintendo Switch Pro Controller+Linux 5.15 (non-HID) does not register thumb sticks - libretro/RetroArch#16905
input_device_display_name = "Nintendo Switch Pro Controller (non-HID) (Bluetooth)"
It seems more straightforward for a single pull request to remove input_vendor_id from all udev files once we reach a consensus on the issue discussed in: libretro/RetroArch#16907
input_device = "Nintendo Switch Pro Controller (Linux 5.15, non-HID) (Bluetooth)"
input_device_display_name = "Nintendo Switch Pro Controller (Linux 5.15, non-HID) (Bluetooth)"
Unnecessary input_vendor_id, and input_product_id in autoconfig files generated by udev - libretro/RetroArch#16904
Removed the final comments
…ller (default-off).cfg Nintendo Co., Ltd. Pro Controller (default-off).cfg
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller.cfgNintendo Co., Ltd. Pro Controller (old).cfg to Nintendo Co., Ltd. Pro Controller (default-off).cfg
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Nintendo Co., Ltd. Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller.cfg
|
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller.cfgNntendo Co., Ltd. Pro Controller (old).cfg to Nintendo Co., Ltd. Pro Controller (default-off).cfg
davidhedlund
changed the title
Nntendo Co., Ltd. Pro Controller (old).cfg to Nintendo Co., Ltd. Pro Controller (default-off).cfgNntendo Co., Ltd. Pro Controller (old).cfg to Nintendo Co., Ltd. Pro Controller (default-off).cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.