-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] sdl2: Update Nintendo Switch Pro Controller.cfg
#1156
Open
davidhedlund
wants to merge
19
commits into
libretro:master
Choose a base branch
from
davidhedlund:patch-40
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d82244b
Update and rename Nintendo Switch Pro Controller.cfg to Nintendo Co.,…
davidhedlund aa3f425
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund 9500e76
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund d1471d8
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund e546bc7
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund 9c9d1c2
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund 35ddfdc
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund ecd06b4
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund e4157b0
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund 660db38
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund 6a60876
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund bc16a9f
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund 29827b8
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund d55235a
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund ffbab5a
Rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro C…
davidhedlund fe785f1
Update Nintendo Switch Pro Controller.cfg
davidhedlund 8e1b49c
Update Nintendo Switch Pro Controller.cfg
davidhedlund 84338f7
Update Nintendo Switch Pro Controller.cfg
davidhedlund 8c02cf1
Update Nintendo Switch Pro Controller.cfg
davidhedlund File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're flipping A/B. RetroArch uses A for right face button, and B for the bottom face button. Is this change correct? You can see a visual of it over at:
https://www.lakka.tv/doc/Input-settings/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct (just generated a test autoconfig to verify it for you), it's generated by RetroArch 1.19.1.
I am confident that every single binding in all pull requests is 100% correct. The only manual additions I've made are for the analog L2/R2 buttons on PlayStation controllers, specifically for drivers that didn't generate them in RetroArch. I maintain a detailed spreadsheet that tracks all controllers, drivers, manual bindings, and bug reports.
All autoconfigurations I've uploaded since the release of RetroArch 1.19.1 have been generated from that version. I've tested every autoconfig 2-3 times.
I'm certain that all pull requests can be approved without the need to merge them and potentially review everything again. I would prefer not to spend additional time on this, as it has already taken a significant amount of effort to reach this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since which RetroArch version (please give me a reference link if possible)?