Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Update Xbox 360 Controller configs #1192

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

landfillbaby
Copy link
Contributor

No description provided.

@landfillbaby landfillbaby changed the title xbox 360 guide button on android android + xbox 360 controller: guide button + fix select button Sep 16, 2024
@landfillbaby
Copy link
Contributor Author

i just noticed something. in the config for the wired version:

input_b_btn_label = "A"
input_y_btn_label = "X"
[...]
input_a_btn_label = "B"
input_x_btn_label = "Y"

but in the wireless adapter version, they're not swapped like that.

this is obviously due to nintendo/xbox differences. but which one is right?

@hizzlekizzle
Copy link
Contributor

I would assume the swapped version is correct from a physical layout standpoint, which is typically how we handle things.

@landfillbaby
Copy link
Contributor Author

ok yes you're right. the config ui also says in brackets to press "B (down)" etc

@landfillbaby landfillbaby changed the title android + xbox 360 controller: guide button + fix select button android + xbox 360 controller: guide button, fix select button, fix A/B and X/Y layout on wireless Sep 16, 2024
@landfillbaby
Copy link
Contributor Author

ready for merge :)

@landfillbaby landfillbaby changed the title android + xbox 360 controller: guide button, fix select button, fix A/B and X/Y layout on wireless android + xbox 360 controller: guide button, fix select button on wired, fix A/B and X/Y layout on wireless Sep 16, 2024
@landfillbaby landfillbaby changed the title android + xbox 360 controller: guide button, fix select button on wired, fix A/B and X/Y layout on wireless [READY] android: add menu button to Microsoft_XBOX_360_Controller_USB.cfg and fix select button, add menu button to Xbox 360 Wireless Adapter.cfg and fix ABXY Sep 16, 2024
@landfillbaby landfillbaby changed the title [READY] android: add menu button to Microsoft_XBOX_360_Controller_USB.cfg and fix select button, add menu button to Xbox 360 Wireless Adapter.cfg and fix ABXY [READY] android: fix and add menu button to Microsoft_XBOX_360_Controller_USB.cfg and Xbox 360 Wireless Adapter.cfg Sep 16, 2024
@landfillbaby
Copy link
Contributor Author

landfillbaby commented Sep 16, 2024

oh just realised this could be merged using libretro/RetroArch#16990. but should it be? they're not an older and newer version like that was intended for, they're a wired and wireless version...

@RobLoach
Copy link
Member

RobLoach commented Sep 17, 2024

Since we're making updates here, I think it would be appropriate to merge the two files and introduce the alt pattern. Also, if you're curious about the button layout for A/B, you'll find it here...
https://www.lakka.tv/doc/Input-settings/

The A button is on the far right. B is the one at the bottom.

@landfillbaby
Copy link
Contributor Author

done :)

@landfillbaby landfillbaby changed the title [READY] android: fix and add menu button to Microsoft_XBOX_360_Controller_USB.cfg and Xbox 360 Wireless Adapter.cfg [READY] android: fix and unify Xbox 360 controller configs Sep 17, 2024
@RobLoach
Copy link
Member

Have you been able to test this on your Android device? Would like to make sure it's working before we merge it.

@landfillbaby
Copy link
Contributor Author

yes i tested and it's fine

@RobLoach RobLoach changed the title [READY] android: fix and unify Xbox 360 controller configs android: Update Xbox 360 Controller configs Sep 28, 2024
@RobLoach RobLoach merged commit f4bd478 into libretro:master Sep 28, 2024
1 check passed
@landfillbaby landfillbaby deleted the patch-1 branch September 28, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants