Fix menu button bindings for 8BitDo SN30 Pro #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite possibly, yeah. Thanks! I can do a test here. |
|
Updated the udev config too, but it's untested, so if you're able to double check it's correct, that's much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu button binding for this controller (in both the Bluetooth and USB configs) is wrong. I'm not sure if it's always been wrong, or if the button mapping has changed in recent firmware, but in any case, none of the buttons on the controller map to button 2. In fact, the menu button (8BitDo "heart" logo) is button 12.
Should I also update the udev configs? They seem to use the exact same mappings as D-Input, so it might make sense, but I don't have a way of testing with udev right now.