New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evals are not always included by default for game exports #285

Merged

niklasf merged 1 commit into lichess-org:master from allanjoseph98:master

Sep 27, 2023

Member

allanjoseph98 commented Sep 27, 2023

Affects multi-game exports where requestPgnFlags is called with extended = false for the following endpoints:

/api/games/user/{username} https://github.com/lichess-org/lila/blob/b82aaf55327f5c142375b50581b3761949eea7d4/app/controllers/Game.scala#L74
/api/games/export/_ids https://github.com/lichess-org/lila/blob/b82aaf55327f5c142375b50581b3761949eea7d4/app/controllers/Game.scala#L123
/api/tournament/{id}/games https://github.com/lichess-org/lila/blob/b82aaf55327f5c142375b50581b3761949eea7d4/app/controllers/Api.scala#L193
/api/swiss/{id}/games https://github.com/lichess-org/lila/blob/b82aaf55327f5c142375b50581b3761949eea7d4/app/controllers/Api.scala#L250

Default values for the other extended opts (clock and opening) are already correct


          Evals are not included by default

3a0d8be

niklasf merged commit 635e880 into lichess-org:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet