Remove chance of unexpected type coercion and remove unnecessary param to TextEncoder
#286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
===
instead of==
and!==
instead of!=
as the latter may cause unexpected type coercion [source].TextEncoder
only supportsutf-8
and does not accept any input params [source]. So we should declare it likeTextEncoder
instead ofTextEncoder('utf-8')
.const
/let
instead ofvar
where appropriate.stringify-object
as it is unused becausepretty
is unused.