New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use outerWidth/outerHeight for powertip hover hitbox #16457

Merged

ornicar merged 1 commit into lichess-org:master from schlawg:ui-powertip-sustain-hover-hitbox

Nov 23, 2024

+3 −3

Collaborator

schlawg commented Nov 22, 2024

this is a more direct fix for #4272 than de56429. but due to the increased surface area, it is for review.

worst case unintended impact would be an overly sticky hover on some element that has huge border/padding. but i doubt that will happen.


          use outerWidth/outerHeight for powertip hover hitbox

fcdad5b

Collaborator Author

schlawg commented Nov 22, 2024

note that isMouseOver function in powertip.ts is only used for sustaining hovers. it is not used when instigating them.

ornicar merged commit baf63e4 into lichess-org:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet