use san rather than chessground callback args for sound #16461
+23
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Nov 23, 2024
| this.ply === 0 | ||
| ? (this.data.game.initialFen ?? 'rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR') | ||
| : this.stepAt(this.ply - 1).fen; | ||
| const san = sanOf(readFen(fen), orig + dest); |
There was a problem hiding this comment.
Pretty sure sanOf(readFen(fen), move) is expensive to run at such a critical moment; that's why the server sends the SAN to the client.
Also I'm not sure that works with variants.
If we want to play a sound before the server sends the SAN back, it should be possible to do so with computing the SAN.
There was a problem hiding this comment.
sanOf(readFen) takes around 2-3 microseconds.
pentatonic uses information such as castles and check which are not readily available from chessground. is it worth separate code paths to shave off a computation we could do a thousand times in a loop without dropping a frame?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unnecessary "music" and "game" sound filters
fix #3109 (was already fixed, but now pentatonic & speech won't lag either)