-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eth steth #459
Eth steth #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to review more, please don't merge yet if no hurry
I'm going to cover all code by tests. I ain't hurrying at all) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good, thank you! 👍
Left some suggestions and considerations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huuuuge 🐘🚀
Left some comments, going to bake more later.
I know lots of the are related to the copied code, sorry. But it looks like a good opportunity to review and improved already existed codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer than ever before 👍
Please consider implementing the suggested changes for the sake of further perfection 😁
ethereum-steth-v2/src/services/steth_operation/StethOperation.spec.ts
Outdated
Show resolved
Hide resolved
ethereum-steth-v2/src/services/steth_operation/StethOperation.spec.ts
Outdated
Show resolved
Hide resolved
ethereum-steth-v2/src/services/steth_operation/StethOperation.srv.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7eeb120
Lido Ethereum StETH bot
Supported chains
Alerts
limit
staking limit)
Development (Forta specific)
Edit
alerting-forta/<SUBMODULE>/forta.config.json
and setjsonRpcUrl
to your JSON-RPC provider. Install deps:Running in a live mode:
Testing on a specific block/range/transaction: