fix: added caching for l1 blocks for l2-bridge-optimism #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyWh1te
force-pushed
the
fix-l1-provider-opt
branch
6 times, most recently
from
6d59075
to
469f041
Compare
sergeyWh1te
force-pushed
the
fix-l1-provider-opt
branch
from
469f041
to
ebb35e9
Compare
TheDZhon
approved these changes
Jul 8, 2024
| @@ -65,33 +65,44 @@ export class BlockHandler { | |||
|
|
|||
| const findings: Finding[] = [] | |||
|
|
|||
| this.logger.info(`#Optimism block: ${l2blockDtoEvent.number}`) | |||
| this.logger.info( | |||
| `#Optimism block: ${l2blockDtoEvent.number} at ${new Date(l2blockDtoEvent.timestamp * 1000).toUTCString()}`, | |||
There was a problem hiding this comment.
can we log l2Block.timestamp too?
| l1BlockNumber.right, | ||
| l2blockDtoEvent.number, | ||
| this.logger.info( | ||
| `#ETH block: ${l1BlockNumber.right.number} at ${new Date(l1BlockNumber.right.timestamp * 1000).toUTCString()}`, |
There was a problem hiding this comment.
Can we log l1Block.timestamp too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for drpc rateLimiting