fet: l2-bridge-arb iterate over l1 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sergeyWh1te
commented
Jul 10, 2024
•
sergeyWh1te
commented
- l2-bridge-arb iterates over l1 network
- It compares bridge balances at the same timestamps on l1 and l2 sides
- Moved findings from l2-bridge-eth to l2-bridge-arb. In other words, all checks happen here, in l2-bridge-arb
- Process all l2 blocks and their logs for detecting events
sergeyWh1te
force-pushed
the
fix-l1-provider-arb
branch
22 times, most recently
from
2c8ecc5
to
594dee0
Compare
sergeyWh1te
force-pushed
the
fix-l1-provider-arb
branch
from
594dee0
to
9ec997b
Compare
sergeyWh1te
force-pushed
the
fix-l1-provider-arb
branch
from
066c474
to
880745f
Compare
TheDZhon
approved these changes
Jul 29, 2024
|
|
||
| return result | ||
| }, | ||
| { delay: 750, maxTry: 10 }, |
There was a problem hiding this comment.
Should we introduce constants?
There was a problem hiding this comment.
do we need seeds for l2 withdrawals?
There was a problem hiding this comment.
Seeds are needed for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.