Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #859

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Version bump #859

wants to merge 3 commits into from

Conversation

LaurenzV
Copy link
Contributor

No description provided.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that under our current policies, this can only be merged by @waywardmonkeys (or RazrFalcon), as they are the only people with the permissions to publish this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these results need to be updated? We have made some changes which I'd naïvely expect to have an impact on the results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, at least in the past few version bumps also only the version was updated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating those charts is a mess.

  1. We have to copy new SVG test files to resvg-test-suite.
  2. Generate reference PNGs, either via resvg or Chrome/resvg-test-suite/tools/chrome-svgrender.
  3. We have to tests them agains all other implementations using resvg-test-suite/tool/vdiff. This would update results.csv
  4. Run resvg-test-suite/stats.py. This would update site/images/chart.svg which should be copied back to resvg.
  5. Run resvg-test-suite/stats.py --svg2. This would update site/images/chart-svg2.svg which should be copied back to resvg.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, missed just one thing.

CHANGELOG.md Show resolved Hide resolved
@waywardmonkeys
Copy link
Collaborator

I think that under our current policies, this can only be merged by @waywardmonkeys (or RazrFalcon), as they are the only people with the permissions to publish this.

I see three ways forward for this:

  1. I merge it in the next 5 - 6 hours and then we hope all goes well as I'll be traveling for about 32 hours and then jet lagged.
  2. I merge it in 48+ hours once I've arrived on the other side of the world and partially recovered.
  3. I grant someone else access on crates.io in addition to me.

Let me know.

@xStrom
Copy link
Member

xStrom commented Dec 12, 2024

Having another Linebender member with crates.io access seems like a good idea in general.

Also something to keep in mind is that this PR needs the changelog release date change on the day of the merge.

@waywardmonkeys
Copy link
Collaborator

Should we publish svgtypes before this crate (non-breaking changes there)?

@LaurenzV
Copy link
Contributor Author

Added the link to the bottom and set the merge date as today (assuming it gets merged today).

@LaurenzV
Copy link
Contributor Author

Should we publish svgtypes before this crate (non-breaking changes there)?

Would make sense I guess. 😄

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.

However if we want SVG Types published before, would have to wait on merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants