feat: add n3-patch support to update-manager #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few style changes regarding spaces are done by my editor's autofmt. As there seems no eslint/prettier rules setted up, i hope it is ok? |
angelo-v
requested changes
Oct 6, 2023
|
Thank you for adding this important feature! |
|
Strange the removal of whitespace before defining parens, which eslint on other projects would add. |
It follows airbnb's js styleguide. As in https://github.com/airbnb/javascript/blob/11ab37144b7f846f04f64a29b5beb6e00d74e84b/packages/eslint-config-airbnb-base/rules/style.js#L486 |
angelo-v
reviewed
Nov 15, 2023
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
Is there anything else i should address? thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473
Also resolves SolidOS/solidos#185