Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to golintci version that is compatible with go 1.21.x #807

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

dpippenger
Copy link
Contributor

Also update golintci configuration to emulate the behavior of the older version. This will resolve #806

…te golintci configuration to emulate the behavior of the older version
@dpippenger dpippenger requested a review from bai as a code owner March 21, 2024 18:40
@dpippenger
Copy link
Contributor Author

I've tested this linter config locally to see that it passes. There are configs that should be re-enabled, but the failures were in pre-existing code and since we already have 1.21.1 merged to master this is necessary to unblock the CI for other unrelated changes.

@bai
Copy link
Collaborator

bai commented Mar 21, 2024

Thanks for your contribution!

@bai bai merged commit 2e716f8 into linkedin:master Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter needs updates after moving master to go 1.21.x
2 participants