Bug fix: handle capitals in Kafka topics (#50)

linkedin · Aug 31, 2023 · 5dc0c2b · 5dc0c2b
1 parent 6e1b6c0
commit 5dc0c2b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/hoptimator-kafka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/KafkaTopic.java b/hoptimator-kafka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/KafkaTopic.java
@@ -2,14 +2,14 @@
 
 import com.linkedin.hoptimator.catalog.Resource;
 
-import java.util.Optional;
-import java.util.Collections;
+import java.util.Locale;
 import java.util.Map;
 
 class KafkaTopic extends Resource {
-  public KafkaTopic(String topicName, Map<String, String> clientOverrides) {
+  KafkaTopic(String topicName, Map<String, String> clientOverrides) {
     super("KafkaTopic");
     export("topicName", topicName);
+    export("topicNameLowerCase", topicName.toLowerCase(Locale.ROOT));
     export("clientOverrides", clientOverrides);
   }
 }

diff --git a/...ator-kafka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/KafkaTopicAcl.java b/...ator-kafka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/KafkaTopicAcl.java
@@ -2,10 +2,13 @@
 
 import com.linkedin.hoptimator.catalog.Resource;
 
+import java.util.Locale;
+
 class KafkaTopicAcl extends Resource {
   public KafkaTopicAcl(String topicName, String principal, String method) {
     super("KafkaTopicAcl");
     export("topicName", topicName);
+    export("topicNameLowerCase", topicName.toLowerCase(Locale.ROOT));
     export("principal", principal);
     export("method", method);
   }

diff --git a/hoptimator-kafka-adapter/src/main/resources/KafkaTopic.yaml.template b/hoptimator-kafka-adapter/src/main/resources/KafkaTopic.yaml.template
@@ -1,7 +1,7 @@
 apiVersion: hoptimator.linkedin.com/v1alpha1
 kind: KafkaTopic
 metadata:
-  name: {{topicName}}
+  name: {{topicNameLowerCase}}
   namespace: {{pipeline.namespace}}
 spec:
   topicName: {{topicName}}

diff --git a/hoptimator-kafka-adapter/src/main/resources/KafkaTopicAcl.yaml.template b/hoptimator-kafka-adapter/src/main/resources/KafkaTopicAcl.yaml.template
@@ -1,11 +1,11 @@
 apiVersion: hoptimator.linkedin.com/v1alpha1
 kind: Acl
 metadata:
-  name: {{topicName}}-acl-{{id}}
+  name: {{topicNameLowerCase}}-acl-{{id}}
   namespace: {{pipeline.namespace}}
 spec:
   resource:
     kind: KafkaTopic
-    name: {{topicName}}
+    name: {{topicNameLowerCase}}
   method: {{method}}
   principal: {{principal}}